s.yahyaee/yara724-api
1
0
Fork 0
forked from Yara724/api
Code Pull Requests Activity

Removed the guard of accidentWay

Browse Source
This commit is contained in:
SepehrYahyaee
2026-07-18 16:03:32 +03:30
parent 482d2b01f1
commit 59a1b9064e
1 changed files with 0 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/request-management/expert-initiated-blame.mirror.controller.ts
View File

@@ -1,6 +1,5 @@
import { extname } from "node:path"; import { extname } from "node:path";
import { import {
BadRequestException,
Body, Body,
Controller, Controller,
Param, Param,
@@ -362,20 +361,6 @@ export class ExpertInitiatedBlameMirrorController {
@CurrentUser() expert: any, @CurrentUser() expert: any,
@UploadedFile() sign: Express.Multer.File, @UploadedFile() sign: Express.Multer.File,
) { ) {
// Guard: accident fields (accidentWay, etc.) must be filled before signing.
// This prevents the expert from bypassing add-accident-fields and avoids the
// double-sign bug where add-accident-fields re-enters WAITING_FOR_SIGNATURES
// after a signature was already recorded.
const requestData = await this.requestManagementService.getBlameRequestV2(
requestId,
expert,
);
if (!(requestData?.expert?.decision as any)?.fields?.accidentWay) {
throw new BadRequestException(
"Accident fields (accidentWay, accidentReason, accidentType) must be submitted via add-accident-fields before signing.",
);
}
await this.mediaPolicyService.assertForBlame(sign, requestId, "image"); await this.mediaPolicyService.assertForBlame(sign, requestId, "image");
const partyRole = const partyRole =
body?.partyRole === "SECOND" ? PartyRole.SECOND : PartyRole.FIRST; body?.partyRole === "SECOND" ? PartyRole.SECOND : PartyRole.FIRST;