HOTFIX: not allowing empty price when expert tries to submit

src/expert-claim/dto/expert-claim-v2.dto.spec.ts

@@ -0,0 +1,27 @@
+import { plainToInstance } from "class-transformer";
+import { validate } from "class-validator";
+import { DaghiOption } from "src/Types&Enums/claim-request-management/daghi-option.enum";
+import { SubmitExpertReplyV2Dto } from "./expert-claim-v2.dto";
+
+describe("SubmitExpertReplyV2Dto", () => {
+  it("rejects a selected damaged part with blank pricing", async () => {
+    const dto = plainToInstance(SubmitExpertReplyV2Dto, {
+      description: "Damage assessment",
+      parts: [
+        {
+          partId: 201,
+          typeOfDamage: "Minor",
+          price: "",
+          salary: "",
+          totalPayment: "",
+          factorNeeded: false,
+          daghi: { option: DaghiOption.NO_VALUE },
+        },
+      ],
+    });
+
+    const errors = await validate(dto);
+
+    expect(errors).not.toHaveLength(0);
+  });
+});

src/expert-claim/dto/expert-claim-v2.dto.ts

@@ -3,6 +3,7 @@ import {
   IsString,
   IsNotEmpty,
   IsArray,
+  ArrayMinSize,
   IsBoolean,
   IsOptional,
   ValidateNested,
@@ -56,6 +57,7 @@ export class PartPricingV2Dto {
     description: "Part price in Toman (integer string). Use 0 if the full amount is in salary.",
   })
   @IsString()
+  @IsNotEmpty()
   @IsRepairLineAmountToman({ allowZero: true })
   price: string;
 
@@ -64,6 +66,7 @@ export class PartPricingV2Dto {
     description: "Labor in Toman (integer string). Use 0 if the full amount is in price.",
   })
   @IsString()
+  @IsNotEmpty()
   @IsRepairLineAmountToman({ allowZero: true })
   salary: string;
 
@@ -72,6 +75,7 @@ export class PartPricingV2Dto {
     description: "Line total in Toman (integer string).",
   })
   @IsString()
+  @IsNotEmpty()
   @IsRepairLineAmountToman()
   totalPayment: string;
 
@@ -101,6 +105,7 @@ export class SubmitExpertReplyV2Dto {
       "One line per damaged part (`partId` from claim detail `damagedParts[]`), plus pricing, `daghi`, and `factorNeeded`.",
   })
   @IsArray()
+  @ArrayMinSize(1)
   @ValidateNested({ each: true })
   @Type(() => PartPricingV2Dto)
   parts: PartPricingV2Dto[];