Centralized SMS services YARA-834

src/auth/auth-services/user.auth.service.ts

@@ -13,8 +13,7 @@ import { LoginDtoRs } from "src/auth/dto/user/login.dto";
 import { UserDbService } from "src/users/entities/db-service/user.db.service";
 import { HashService } from "src/utils/hash/hash.service";
 import { OtpService } from "src/utils/otp/otp.service";
-import { SmsManagerService } from "src/utils/sms-manager/sms-manager.service";
-import { describeSmsError } from "src/utils/sms-manager/sms-provider.exception";
+import { SmsOrchestrationService } from "src/sms-orchestration/sms-orchestration.service";
 
 // TODO FIX REGISTER TO USER.SERVICE AND AUTH IN THIS MODULE
 @Injectable()
@@ -26,7 +25,7 @@ export class UserAuthService {
     private readonly userDbService: UserDbService,
     private readonly hashService: HashService,
     private readonly otpCreator: OtpService,
-    private readonly smsManagerService: SmsManagerService,
+    private readonly smsOrchestrationService: SmsOrchestrationService,
   ) {}
 
   async validateUser(username: string, pass: string): Promise<any> {
@@ -118,26 +117,19 @@ export class UserAuthService {
   }
 
   private async smsSender(otp: string, mobile: string) {
-    try {
-      await this.smsManagerService.verifyLookUp({
-        token: otp,
-        template: process.env.AUTH_SMS_TEMPLATE,
-        receptor: mobile,
-      });
-      this.logger.log(
-        `Auth OTP SMS accepted by provider phone=${mobile} otp=${otp}`,
-      );
-    } catch (err) {
-      this.logger.error(
-        `Auth OTP SMS failed phone=${mobile} otp=${otp} ${describeSmsError(err)}`,
-      );
-      if (err instanceof HttpException) {
-        throw err;
-      }
+    const ok = await this.smsOrchestrationService.sendAuthOtp(
+      mobile,
+      otp,
+      process.env.AUTH_SMS_TEMPLATE,
+    );
+    if (!ok) {
       throw new HttpException(
         "auth sms send failed",
         HttpStatus.BAD_GATEWAY,
       );
     }
+    this.logger.log(
+      `Auth OTP SMS accepted by provider phone=${mobile} otp=${otp}`,
+    );
   }
 }

src/auth/auth.module.ts

@@ -12,7 +12,7 @@ import { UsersModule } from "src/users/users.module";
 import { HashModule } from "src/utils/hash/hash.module";
 // import { MailModule } from "src/utils/mail/mail.module";
 import { OtpModule } from "src/utils/otp/otp.module";
-import { SmsManagerModule } from "src/utils/sms-manager/sms-manager.module";
+import { SmsOrchestrationModule } from "src/sms-orchestration/sms-orchestration.module";
 
 @Module({
   imports: [
@@ -22,7 +22,7 @@ import { SmsManagerModule } from "src/utils/sms-manager/sms-manager.module";
     HashModule,
     OtpModule,
     PassportModule,
-    SmsManagerModule,
+    SmsOrchestrationModule,
     JwtModule.register({
       signOptions: { expiresIn: "1h" },
       global: true,