feat(tenant): add tenant_domains allowlist and /v1/domains management API
Why: - Domain values are denormalized into every Qdrant point payload. Without validation, an unregistered or typo'd domain (e.g. "fier" for "fire") silently creates a new partition that retrieval never queries — the file ends up invisible rather than rejected. Tenants also need independently sized domain sets (one may run 14 insurance lines, another 6), which rules out an enum. Changes: - tenant_domains table (migration 41335d162de8) + repository, unique on (tenant_id, domain). - src/application/domains/: ensure_domain_allowed() is the strict-allowlist check now run inside upload_source_file()'s first transaction, before any MinIO object, job row, or Qdrant point is written. - /v1/domains (list/create/patch/disable/enable) gated on its own domains:read/domains:write scopes, deliberately separate from files:write so an upload key cannot create partitions. domain itself is immutable (denormalized into every point payload); only display_name is editable. Disable blocks new uploads without touching already-indexed points. Impact: - BREAKING: POST /v1/files now rejects any domain without an active tenant_domains row (400, unknown_domain). A domain must be created via POST /v1/domains before the first upload to it.
This commit is contained in:
@@ -98,13 +98,16 @@ One row per customer/tenant.
|
||||
| `slug` | Stable short name, unique, human-readable. |
|
||||
| `name` | Display name. |
|
||||
| `status` | `active` \| `suspended` \| `deleted`. Suspended tenants authenticate to a clear error but cannot run work. |
|
||||
| `settings` | JSONB for tenant-level feature flags/limits (max upload size, enabled file types, allowed domains, etc.). |
|
||||
| `settings` | JSONB for tenant-level feature flags/limits (max upload size, enabled file types, etc.). Allowed domains were previously listed here as well; they live in `tenant_domains` instead, per this ADR's own rule that query-critical fields get typed columns — `domain` is validated on every upload and filtered on every query. |
|
||||
| `created_at`, `updated_at`, `deleted_at` | Audit/soft-delete timestamps. |
|
||||
|
||||
#### `tenant_domains`
|
||||
|
||||
Optional but recommended. Validates the `domain` values used throughout Qdrant
|
||||
payloads (`car`, `fire`, etc.) per tenant.
|
||||
**Required.** (Previously "optional but recommended"; implemented and made
|
||||
mandatory alongside `/v1/domains`.) Validates the `domain` values used
|
||||
throughout Qdrant payloads (`car`, `fire`, etc.) per tenant. Domain sets are
|
||||
per-tenant and differ in size — one tenant may run 14 insurance lines and
|
||||
another 6 — so this is data, not an enum.
|
||||
|
||||
| Column | Notes |
|
||||
|---|---|
|
||||
@@ -116,7 +119,37 @@ payloads (`car`, `fire`, etc.) per tenant.
|
||||
| `metadata` | JSONB for domain-specific ingestion/retrieval settings. |
|
||||
|
||||
This prevents arbitrary caller-supplied domains from silently creating new
|
||||
partitions in Qdrant.
|
||||
partitions in Qdrant. The failure it guards against is quiet: a typo such as
|
||||
`fier` for `fire` produces no error anywhere — the file is stored, parsed,
|
||||
embedded, and indexed into a partition retrieval never queries, so it is
|
||||
invisible rather than failed.
|
||||
|
||||
##### Enforcement and management
|
||||
|
||||
- **Strict allowlist.** `POST /v1/files` rejects a domain with no `active` row
|
||||
for the tenant (`400`, error code `unknown_domain`). There is no auto-create
|
||||
on first use: that would record the typo rather than prevent it. The check
|
||||
runs inside the upload's first transaction, before any MinIO object, job row,
|
||||
or Qdrant point is written.
|
||||
- **Managed over the API, not by an operator.** `/v1/domains` (list, create,
|
||||
update, disable, enable) is the surface the calling backend uses. Domains are
|
||||
created by an explicit, scoped call rather than as a side effect of an upload
|
||||
— that distinction, not who makes the call, is what "strict" means here.
|
||||
- **Its own scope.** `domains:read`/`domains:write`, deliberately separate from
|
||||
`files:write`. Folding domain creation into the upload scope would let an
|
||||
upload key create partitions again, which is the exact hole this closes.
|
||||
`api_keys.scopes` is already a free JSONB list, so this needs no schema change.
|
||||
- **`tenant_id` stays derived from the API key.** One key per tenant; nothing
|
||||
request-suppliable. A platform key acting across tenants would need a real
|
||||
actor model and is not adopted.
|
||||
- **`domain` is immutable; `display_name` is not.** The key is denormalized into
|
||||
every Qdrant point payload and into `source_files`, so renaming it means
|
||||
rewriting all of them — a migration, not a `PATCH`. The update schema
|
||||
therefore has no `domain` field.
|
||||
- **Disable is not delete.** `status='disabled'` blocks new uploads and hides
|
||||
the domain from listings, leaving already-indexed points intact and
|
||||
retrievable. Actual removal needs the retention/erasure workflow this ADR and
|
||||
plan 001 defer.
|
||||
|
||||
#### `api_keys`
|
||||
|
||||
|
||||
Reference in New Issue
Block a user